Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[windows] Make event.original optional and update to ECS 1.10 #1122

Merged
merged 2 commits into from
Jun 14, 2021
Merged

[windows] Make event.original optional and update to ECS 1.10 #1122

merged 2 commits into from
Jun 14, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jun 14, 2021

What does this PR do?

  • Makes event.original optional
  • Adds custom processors option
  • Add tags to all inputs
  • Update to ECS 1.10

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

Screenshots

image

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@marc-gr marc-gr mentioned this pull request Jun 14, 2021
Closed
43 tasks
@elasticmachine
Copy link

elasticmachine commented Jun 14, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1122 updated

  • Start Time: 2021-06-14T14:48:37.557+0000

  • Duration: 21 min 44 sec

  • Commit: e0ad3eb

Test stats 🧪

Test Results
Failed 0
Passed 126
Skipped 0
Total 126

Trends 🧪

Image of Build Times

Image of Tests

P1llus
P1llus approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great work! :)

@marc-gr marc-gr merged commit 68e7535 into elastic:master Jun 14, 2021
@marc-gr marc-gr deleted the windows-event.original branch June 14, 2021 15:17
james-elastic pushed a commit to james-elastic/integrations that referenced this pull request Jun 30, 2021
@marc-gr @james-elastic
[windows] Make event.original optional and update to ECS 1.10 (elasti…
ff93e0d 
…c#1122)

* Make event.original optional and update to ECS 1.10

* Update changelog.yml
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@marc-gr
[windows] Make event.original optional and update to ECS 1.10 (elasti…
3b84564 
…c#1122)

* Make event.original optional and update to ECS 1.10

* Update changelog.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marc-gr @elasticmachine @P1llus