Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] Use wildcard field type #1161

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jun 22, 2021

What does this PR do?

Uses wildcard field type for the relevant ECS fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

@elasticmachine
Copy link

elasticmachine commented Jun 22, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2021-06-23T11:17:16.098+0000

  • Duration: 22 min 47 sec

  • Commit: 9235a72

Test stats 🧪

Test Results
Failed 0
Passed 126
Skipped 0
Total 126

Trends 🧪

Image of Build Times

Image of Tests

@marc-gr marc-gr mentioned this pull request Jun 22, 2021
43 tasks
@marc-gr marc-gr changed the title [windows] Use wildcard type [windows] Use referenced ECS fields Jun 23, 2021
@marc-gr marc-gr changed the title [windows] Use referenced ECS fields [windows] Use wildcard field type Jun 23, 2021
@marc-gr marc-gr mentioned this pull request Jun 23, 2021
10 tasks
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr marc-gr merged commit 7333672 into elastic:master Jun 23, 2021
@marc-gr marc-gr deleted the windows-wildcard branch June 23, 2021 12:32
james-elastic pushed a commit to james-elastic/integrations that referenced this pull request Jun 30, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants