Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nginx Ingress Controller] Set event.module and event.dataset #1226

Merged
merged 3 commits into from
Jun 29, 2021
Merged

[Nginx Ingress Controller] Set event.module and event.dataset #1226

merged 3 commits into from
Jun 29, 2021

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Jun 28, 2021 •
edited
Loading

What does this PR do?

This PR adds event.module and event.dataset to the integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

@mtojek mtojek self-assigned this Jun 28, 2021
@elasticmachine
Copy link

elasticmachine commented Jun 28, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2021-06-28T22:28:23.884+0000

  • Duration: 12 min 16 sec

  • Commit: b7e0d93

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

Trends 🧪

Image of Build Times

Image of Tests

@mtojek mtojek marked this pull request as ready for review June 29, 2021 08:00
@mtojek mtojek added the Team:Integrations Label for the Integrations team label Jun 29, 2021
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

ChrsMark
ChrsMark approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mtojek mtojek merged commit 9d213e9 into elastic:master Jun 29, 2021
james-elastic pushed a commit to james-elastic/integrations that referenced this pull request Jun 30, 2021
@mtojek @james-elastic
[Nginx Ingress Controller] Set event.module and event.dataset (elasti…
1ae5f4c 
…c#1226)

* [Nginx Ingress Controller] Set event.module and event.dataset

* Update changelog

* Update docs
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@mtojek
[Nginx Ingress Controller] Set event.module and event.dataset (elasti…
64662e8 
…c#1226)

* [Nginx Ingress Controller] Set event.module and event.dataset

* Update changelog

* Update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@mtojek mtojek

Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mtojek @elasticmachine @ChrsMark