Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kibana Package #1519

Merged
merged 17 commits into from
Sep 27, 2021
Merged

Kibana Package #1519

merged 17 commits into from
Sep 27, 2021

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Aug 11, 2021 •
edited
Loading

What does this PR do?

Adds the Kibana to the list of available integrations.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.15.0).

Related issues

Screenshots

image

image

image

@sayden sayden self-assigned this Aug 11, 2021
@sayden sayden added enhancement New feature or request Team:Integrations Label for the Integrations team Team:Services (Deprecated) Label for the former Integrations-Services team labels Aug 11, 2021
@elasticmachine
Copy link

elasticmachine commented Aug 11, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-23T12:32:43.655+0000

  • Duration: 11 min 39 sec

  • Commit: 9aa8017

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@sayden sayden marked this pull request as ready for review August 13, 2021 12:02
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link

Pinging @elastic/integrations-services (Team:Services)

@mtojek mtojek self-requested a review August 13, 2021 12:17
mtojek
mtojek reviewed Aug 13, 2021
View reviewed changes
packages/kibana/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/kibana/data_stream/log/fields/ecs.yml Outdated Show resolved Hide resolved
packages/kibana/data_stream/log/manifest.yml Outdated
@@ -0,0 +1,17 @@
type: logs
title: kibana log logs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log logs might be confusing for users :) I used to rephrase them to "application logs" or "standard logs".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch! Or "Da logs". Nope, sorry, this passed under my radar.

packages/kibana/data_stream/stats/fields/package-fields.yml Show resolved Hide resolved
packages/kibana/manifest.yml Outdated Show resolved Hide resolved
packages/kibana/manifest.yml Show resolved Hide resolved
@jasonrhodes jasonrhodes mentioned this pull request Aug 13, 2021
Closed
3 tasks
@masci masci linked an issue Aug 24, 2021 that may be closed by this pull request
Migrate kibana integration #368
Closed
17 tasks
mtojek
mtojek reviewed Sep 9, 2021
View reviewed changes
packages/kibana/data_stream/status/fields/fields.yml Outdated Show resolved Hide resolved
packages/kibana/manifest.yml Show resolved Hide resolved
packages/kibana/data_stream/log/fields/ecs.yml Outdated Show resolved Hide resolved
@sayden
Copy link
Contributor Author

sayden commented Sep 23, 2021 •
edited
Loading

ECS 1.12 will be updated in a follow up, once it is released in Github. Merging is possible

mtojek
mtojek approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for addressing PR comments!

@sayden sayden merged commit b930992 into elastic:master Sep 27, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@sayden
Kibana Package (elastic#1519)
122ae13
@sayden sayden deleted the migration/sm/kibana branch July 30, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@sayden sayden

Labels
enhancement New feature or request Team:Integrations Label for the Integrations team Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate kibana integration
3 participants
@sayden @elasticmachine @mtojek