New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System integration improvements #1548
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
Pinging @elastic/integrations (Team:Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert on the windows stuff in particular, but the changes LGTM.
@P1llus can you take a look. This should address the requests that came in via Slack. |
- Add custom processors - Add event_id selection - Applies to Application, Security & System data_streams
d0cbcdd
to
bac4b1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I know that @marc-gr has started adding in an extra check that tags are never empty in case a user removes existing tags, we don't necessarily need to add that in now though, its up to you.
* System integration improvements - Add custom processors - Add event_id selection - Applies to Application, Security & System data_streams
What does this PR do?
Changes to System integration:
Checklist
changelog.yml
file.- [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package'smanifest.yml
file to point to the latest Elastic stack release (e.g.^7.13.0
).Author's Checklist
How to test this PR locally
Related issues
Screenshots