Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System integration improvements #1548

Merged
merged 2 commits into from Aug 27, 2021

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Aug 20, 2021

What does this PR do?

Changes to System integration:

  • Add custom processors
  • Add event_id selection
  • Applies to Application, Security & System data_streams

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

How to test this PR locally

  • Test on Windows host

Related issues

Screenshots

Screen Shot 2021-08-20 at 10 12 46

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Aug 20, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-26T22:27:12.662+0000

  • Duration: 15 min 37 sec

  • Commit: bac4b1d

Test stats 🧪

Test Results
Failed 0
Passed 266
Skipped 0
Total 266

Trends 🧪

Image of Build Times

Image of Tests

@masci masci added the Team:Integrations Label for the Integrations team label Aug 23, 2021
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

Copy link
Contributor

@fearful-symmetry fearful-symmetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert on the windows stuff in particular, but the changes LGTM.

@leehinman
Copy link
Contributor Author

@P1llus can you take a look. This should address the requests that came in via Slack.

@leehinman leehinman requested a review from P1llus August 26, 2021 22:22
- Add custom processors
- Add event_id selection
- Applies to Application, Security & System data_streams
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I know that @marc-gr has started adding in an extra check that tags are never empty in case a user removes existing tags, we don't necessarily need to add that in now though, its up to you.

@leehinman leehinman merged commit ed14521 into elastic:master Aug 27, 2021
@leehinman leehinman deleted the event_id_custom_proc branch August 27, 2021 20:23
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
* System integration improvements

- Add custom processors
- Add event_id selection
- Applies to Application, Security & System data_streams
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants