Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveMQ_package(#606) #1550

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

kush-crest
Copy link
Contributor

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • Each data streams should contains system tests.
  • Each data streams should contains sample_event.json.
  • Each data streams should successfully pass all tests.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/activemq directory.
  • Run following command to run system tests. elastic-package test system -v

Related issues

@kush-crest kush-crest added enhancement New feature or request Integration:activemq ActiveMQ labels Aug 23, 2021
@kush-crest kush-crest assigned kush-crest and unassigned kush-crest Aug 23, 2021
@elasticmachine
Copy link

elasticmachine commented Aug 23, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-30T15:03:48.161+0000

  • Duration: 17 min 6 sec

  • Commit: b31a5c0

Test stats 🧪

Test Results
Failed 0
Passed 52
Skipped 0
Total 52

Trends 🧪

Image of Build Times

Image of Tests

@kush-crest kush-crest force-pushed the create_activemq_integration_#606 branch from 7851ca6 to 0dc78d0 Compare August 23, 2021 11:58
@jsoriano
Copy link
Member

/test

@kush-crest kush-crest force-pushed the create_activemq_integration_#606 branch from 0dc78d0 to b353fa9 Compare August 24, 2021 04:12
@kush-crest kush-crest force-pushed the create_activemq_integration_#606 branch from b353fa9 to 16cf570 Compare August 24, 2021 05:47
@jsoriano
Copy link
Member

/test

packages/activemq/_dev/deploy/docker/Dockerfile Outdated Show resolved Hide resolved
packages/activemq/data_stream/broker/fields/ecs.yml Outdated Show resolved Hide resolved
packages/activemq/data_stream/queue/fields/fields.yml Outdated Show resolved Hide resolved
packages/activemq/data_stream/queue/manifest.yml Outdated Show resolved Hide resolved
packages/activemq/data_stream/log/manifest.yml Outdated Show resolved Hide resolved
packages/activemq/data_stream/log/fields/ecs.yml Outdated Show resolved Hide resolved
packages/activemq/data_stream/queue/fields/ecs.yml Outdated Show resolved Hide resolved
packages/activemq/data_stream/topic/fields/ecs.yml Outdated Show resolved Hide resolved
packages/activemq/manifest.yml Outdated Show resolved Hide resolved
@jsoriano
Copy link
Member

/test

These fields help you find and correlate logs for a specific service and version.'
type: group
fields:
- name: type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

service.type is an ECS field, you can define it in ecs.yml as an external field. (And service.address will be in ECS 1.12 elastic/ecs#1537).

@jsoriano jsoriano merged commit a050b84 into elastic:master Aug 30, 2021
@sayden sayden mentioned this pull request Sep 8, 2021
4 tasks
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@kush-elastic kush-elastic mentioned this pull request Sep 20, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:activemq ActiveMQ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants