Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Osquery_manager: Update host.ip field mapping from keyword to ip data type #1574

Merged
merged 3 commits into from Sep 3, 2021
Merged

Osquery_manager: Update host.ip field mapping from keyword to ip data type #1574

merged 3 commits into from Sep 3, 2021

Conversation

aleksmaus
Copy link
Member

What does this PR do?

Updates host.ip field mapping from keyword to ip data type. Addresses https://discuss.elastic.co/t/osquery-manager-integration-mapping-ip-host-ip-as-keyword/283225

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

Screenshots

Before the change:
Screen Shot 2021-09-03 at 1 52 38 PM

After the change:
Screen Shot 2021-09-03 at 2 08 04 PM

@aleksmaus aleksmaus added enhancement New feature or request v7.16.0 v7.15.0 Team:Asset Mgt Label for the Security Assets Management team labels Sep 3, 2021
@elasticmachine
Copy link

elasticmachine commented Sep 3, 2021 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-03T18:53:53.970+0000

  • Duration: 10 min 7 sec

  • Commit: 49f5363

Test stats 🧪

Test Results
Failed 0
Passed 1
Skipped 0
Total 1

Trends 🧪

Image of Build Times

Image of Tests

@aleksmaus
Copy link
Member Author

/test

melissaburpo
melissaburpo approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@melissaburpo melissaburpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aleksmaus aleksmaus merged commit 1d28bf2 into elastic:master Sep 3, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@aleksmaus
Osquery_manager: Update host.ip field mapping from keyword to ip data…
4fb6c73 
… type (elastic#1574)

* Osquery_manager: Update host.ip field mapping from keyword to ip data type

* Update PR number in the changelog

* Format ecs.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melissaburpo melissaburpo melissaburpo approved these changes

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski

@james-elastic james-elastic Awaiting requested review from james-elastic

Assignees
No one assigned
Labels
enhancement New feature or request Team:Asset Mgt Label for the Security Assets Management team v7.15.0 v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aleksmaus @elasticmachine @melissaburpo