Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snort] Add Snort Integration #1575

Merged
merged 11 commits into from
Sep 30, 2021
Merged

[Snort] Add Snort Integration #1575

merged 11 commits into from
Sep 30, 2021

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Sep 4, 2021 •
edited
Loading

What does this PR do?

Add Snort integration

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • [ ]

How to test this PR locally

cd integrations/packages/snort
elastic-package stack down && elastic-package build && elastic-package stack up -d -v -p default && eval "$(elastic-package stack shellinit)" && elastic-package test  -v

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Sep 4, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-30T09:48:19.233+0000

  • Duration: 14 min 51 sec

  • Commit: 3adccf3

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@legoguy1000 legoguy1000 mentioned this pull request Sep 6, 2021
Closed
@P1llus
Copy link
Member

P1llus commented Sep 14, 2021

/test

@legoguy1000 legoguy1000 marked this pull request as ready for review September 26, 2021 23:45
@P1llus
Copy link
Member

P1llus commented Sep 30, 2021

/test

P1llus
P1llus approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could bump minimum version to 7.16 I could merge right away

@P1llus P1llus merged commit 61b9567 into elastic:master Sep 30, 2021
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@legoguy1000 legoguy1000 deleted the 937-snort-package branch September 30, 2021 10:49
@legoguy1000 legoguy1000 mentioned this pull request Oct 19, 2021
Closed
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@legoguy1000
[Snort] Add Snort Integration (elastic#1575)
3571366 
* elastic#937 Add Snort Integration

* Add CSV and Alert Full logs

* Add syslog

* update system tests

* add multiline, update agents

* Update pipeline tests

* updates from panw changes

* Update ECS to 1.12

* add observer fields

* Fix system tests

* bump to 7.16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Snort module
3 participants
@legoguy1000 @elasticmachine @P1llus