Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move defender_atp to new GA package microsoft_defender_endpoint #1777

Merged
merged 11 commits into from
Sep 30, 2021
Merged

Move defender_atp to new GA package microsoft_defender_endpoint #1777

merged 11 commits into from
Sep 30, 2021

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Sep 29, 2021

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

Relates #1562

Screenshots

Screenshot 2021-09-29 at 21-11-48 Microsoft Defender for Endpoint - Integrations - Elastic

Screenshot 2021-09-29 at 21-09-16 Add integration - Microsoft Defender for Endpoint - Integrations - Elastic

@elasticmachine
Copy link

elasticmachine commented Sep 29, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-30T16:37:20.607+0000

  • Duration: 16 min 35 sec

  • Commit: 10c78bf

Test stats 🧪

Test Results
Failed 0
Passed 33
Skipped 0
Total 33

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, feel free to ignore any that you think is not necessary :)

@@ -0,0 +1,3 @@
dependencies:
ecs:
reference: git@1.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we bump this to 1.12?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

changes:
- description: First version
type: enhancement
link: https://github.com/elastic/integrations/pull/NNN
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a link to the github issue here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

value: '{{_ingest.timestamp}}'
- set:
field: ecs.version
value: '1.11.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we bump this to 1.12?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

license: basic
type: integration
conditions:
kibana.version: "^7.14.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit unsure if we want to bump this to 7.16.0, same with the deprecation of the old one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now we will keep this set to the latest compatible version of kibana

adriansr and others added 8 commits September 30, 2021 11:22
Moves the microsoft.defender_atp datastream into a new package:
microsoft_defender_endpoint.

This new package is GA.

Relates #1562
Co-authored-by: Lee E Hinman <57081003+leehinman@users.noreply.github.com>
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing.

@adriansr adriansr merged commit 966e59f into elastic:master Sep 30, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
…tic#1777)

- Moves the microsoft.defender_atp datastream into a new package:
  microsoft_defender_endpoint. This new package is GA.

- Reverts changes added by elastic#1765 as we're planning to deprecate 
  the microsoft package.

Co-authored-by: Lee E Hinman <57081003+leehinman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants