-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move defender_atp to new GA package microsoft_defender_endpoint #1777
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments, feel free to ignore any that you think is not necessary :)
@@ -0,0 +1,3 @@ | |||
dependencies: | |||
ecs: | |||
reference: git@1.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we bump this to 1.12?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
changes: | ||
- description: First version | ||
type: enhancement | ||
link: https://github.com/elastic/integrations/pull/NNN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a link to the github issue here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
value: '{{_ingest.timestamp}}' | ||
- set: | ||
field: ecs.version | ||
value: '1.11.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we bump this to 1.12?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
license: basic | ||
type: integration | ||
conditions: | ||
kibana.version: "^7.14.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit unsure if we want to bump this to 7.16.0, same with the deprecation of the old one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now we will keep this set to the latest compatible version of kibana
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for fixing.
…tic#1777) - Moves the microsoft.defender_atp datastream into a new package: microsoft_defender_endpoint. This new package is GA. - Reverts changes added by elastic#1765 as we're planning to deprecate the microsoft package. Co-authored-by: Lee E Hinman <57081003+leehinman@users.noreply.github.com>
What does this PR do?
microsoft_defender_endpoint
. This new package is GA.Checklist
changelog.yml
file.manifest.yml
file to point to the latest Elastic stack release (e.g.^7.13.0
).Related issues
Relates #1562
Screenshots