Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pulse Connect Secure #1998

Merged
merged 7 commits into from
Dec 8, 2021
Merged

Add Pulse Connect Secure #1998

merged 7 commits into from
Dec 8, 2021

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Oct 20, 2021 •
edited
Loading

What does this PR do?

Add Pulse Connect Secure integration

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 changed the title #1927: Add Pulse Connect Secure Add Pulse Connect Secure Oct 20, 2021
@elasticmachine
Copy link

elasticmachine commented Oct 20, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-08T13:57:59.849+0000

  • Duration: 16 min 16 sec

  • Commit: ef3c4d4

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@zez3
Copy link

zez3 commented Dec 2, 2021

@P1llus Can someone please 🙏 have a look at this and include it in the upcoming release. If not possible anymore in 7.16 then 7.16.1
Thanks a bunch.

@legoguy1000
Copy link
Contributor Author

I started this and let it drop. I'll try to finish it up this week/weekend so it can be reviewed and merged.

@zez3
Copy link

zez3 commented Dec 3, 2021 •
edited
Loading

Great work, I was hoping to get this in 7.16
Is this really expecting kibana v8 to function?
I saw some option like bellow on other packages:
kibana.version: "^7.16 | ^8.0.0"

@legoguy1000
Copy link
Contributor Author

Thats up to @P1llus and team. Every integration i've made recently has been for 8.0.0. I can change it to 7.16 if they're good with it.

@P1llus
Copy link
Member

P1llus commented Dec 3, 2021

@jamiehynds ?

@legoguy1000 legoguy1000 marked this pull request as ready for review December 4, 2021 16:05
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@legoguy1000
Copy link
Contributor Author

Ready for initial review. Passed all local tests.

@efd6
Copy link
Contributor

efd6 commented Dec 6, 2021

/test

@jamiehynds
Copy link

Thats up to @P1llus and team. Every integration i've made recently has been for 8.0.0. I can change it to 7.16 if they're good with it.

Given that it will take some time for folks to upgrade to 8.0, if there's no technical blocker to including the integration as part of 7.16, fine on my end.

@P1llus
Copy link
Member

P1llus commented Dec 8, 2021

/test

@P1llus
Copy link
Member

P1llus commented Dec 8, 2021

Feel free to bump this to 1.0.0 since we have proper system and pipeline test coverage @legoguy1000

@P1llus P1llus merged commit 6ea5742 into elastic:master Dec 8, 2021
@legoguy1000 legoguy1000 deleted the 1927-pulse-secure branch December 8, 2021 19:43
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@legoguy1000
Add Pulse Connect Secure (elastic#1998)
d3cde52 
* elastic#1927: Add Pulse Connect Secure

* remove old fields

* update pipeline and fields

* additional changes

* minor fixes

* change to 7.16.0

* fix null check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zez3 zez3 zez3 left review comments

@olmanolsztyn olmanolsztyn olmanolsztyn left review comments

@P1llus P1llus P1llus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Pulse Secure Connect integration support
7 participants
@legoguy1000 @elasticmachine @zez3 @P1llus @efd6 @jamiehynds @olmanolsztyn