Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Juniper] Split Juniper SRX datastream into separate package #2068

Merged
merged 6 commits into from
Nov 23, 2021
Merged

[Juniper] Split Juniper SRX datastream into separate package #2068

merged 6 commits into from
Nov 23, 2021

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Split Juniper SRX datastream into separate package

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • [ ]

How to test this PR locally

cd packages/juniper_srx
elastic-package build && elastic-package stack down && elastic-package stack up --version 7.16.0-SNAPSHOT -d -v && eval "$(elastic-package stack shellinit)" && elastic-package test -v

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Oct 30, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-23T07:49:50.028+0000

  • Duration: 16 min 23 sec

  • Commit: 3c96581

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@legoguy1000 legoguy1000 marked this pull request as ready for review October 30, 2021 21:05
@P1llus
Copy link
Member

P1llus commented Nov 1, 2021

/test

@P1llus
Copy link
Member

P1llus commented Nov 1, 2021

@legoguy1000 Could you bump this to 8.0?

@P1llus
Copy link
Member

P1llus commented Nov 1, 2021

/test

@P1llus P1llus requested a review from a team November 17, 2021 17:55
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@P1llus
Copy link
Member

P1llus commented Nov 17, 2021

/test

@P1llus
Copy link
Member

P1llus commented Nov 23, 2021

/test

P1llus
P1llus approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@P1llus P1llus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good :)

@P1llus P1llus merged commit 8b48bda into elastic:master Nov 23, 2021
@legoguy1000 legoguy1000 deleted the 1934-juniper-srx branch November 23, 2021 11:02
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@legoguy1000
[Juniper] Split Juniper SRX datastream into separate package (elastic…
c5a034e 
…#2068)

* elastic#1934: Split Juniper SRX datastream into separate package

* update changelog

* use filestream input

* bump to 8.0.0

* update generated data

* update data with GeoIP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@legoguy1000 @elasticmachine @P1llus