Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Package] UDP Input #2170

Merged
merged 5 commits into from
Nov 25, 2021
Merged

[New Package] UDP Input #2170

merged 5 commits into from
Nov 25, 2021

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Nov 17, 2021

What does this PR do?

This package adds the possibility to configure your own custom UDP input, allowing users to add custom integrations that might not already be covered by an existing package.

Tested with 7.16 and 8.0

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

@P1llus P1llus added enhancement New feature or request Team:Integrations Label for the Integrations team Team:Security-External Integrations labels Nov 17, 2021
@P1llus P1llus requested review from a team November 17, 2021 11:53
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Nov 17, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-19T07:18:14.590+0000

  • Duration: 12 min 0 sec

  • Commit: 43ab5e0

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@zez3
Copy link

zez3 commented Nov 17, 2021

Was there not already decided to include the user selectable option to keep the original message on all integrations?

@P1llus
Copy link
Member Author

P1llus commented Nov 17, 2021

Was there not already decided to include the user selectable option to keep the original message on all integrations?

Sure thing @zez3 .

Since these are pure input packages, the incoming data is always the raw format, it is up to the end-user to parse/transform the data in the way that they want, and are then also free to keep the original.

Copy link
Member

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on title and description!

@zez3
Copy link

zez3 commented Nov 22, 2021

Was there not already decided to include the user selectable option to keep the original message on all integrations?

Sure thing @zez3 .

Since these are pure input packages, the incoming data is always the raw format, it is up to the end-user to parse/transform the data in the way that they want, and are then also free to keep the original.

But the commit 1b5dec1

removes the original message? Or am I missing something here

@P1llus
Copy link
Member Author

P1llus commented Nov 25, 2021

Was there not already decided to include the user selectable option to keep the original message on all integrations?

Sure thing @zez3 .
Since these are pure input packages, the incoming data is always the raw format, it is up to the end-user to parse/transform the data in the way that they want, and are then also free to keep the original.

But the commit 1b5dec1

removes the original message? Or am I missing something here

Hello @zez3 . That is because when I make packages I simply copy/paste an existing package usually. The input only packages do not need this part, as it will always come in raw.
That setting is not for the input to keep the original, is for the ingest pipelines to make sure to leave a copy of the original event before it starts modifying it.

@P1llus P1llus merged commit a1c5680 into elastic:master Nov 25, 2021
@jamiehynds jamiehynds mentioned this pull request Dec 8, 2021
8 tasks
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
* Initial commit

* update changelog and make tags config safer

* removing preserve original as its not related to custom inputs

* updating manifest from PR comments

* update ecs version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants