Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fortinet/Firewall Filebeat Module #228

Merged
merged 2 commits into from Aug 6, 2020
Merged

Fortinet/Firewall Filebeat Module #228

merged 2 commits into from Aug 6, 2020

Conversation

andrewstucki
Copy link
Contributor

What does this PR do?

This adds support for the fortinet.firewall fileset from filebeat.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Screenshots

Screen Shot 2020-08-05 at 10 12 48 AM

Screen Shot 2020-08-05 at 10 12 59 AM

Screen Shot 2020-08-05 at 10 13 08 AM

Screen Shot 2020-08-05 at 10 13 27 AM

Screen Shot 2020-08-05 at 10 13 33 AM

Screen Shot 2020-08-05 at 10 13 39 AM

Screen Shot 2020-08-05 at 10 44 12 AM

@andrewstucki andrewstucki added enhancement New feature or request Team:Integrations Label for the Integrations team Team:SIEM labels Aug 5, 2020
@elasticmachine
Copy link

Pinging @elastic/siem (Team:SIEM)

@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #228 opened]

  • Start Time: 2020-08-05T14:50:50.386+0000

  • Duration: 4 min 46 sec

@mtojek mtojek self-requested a review August 6, 2020 11:27
mtojek
mtojek approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit: I noticed that some abbreviations (tcp, udp) could be written with uppercase. Not blocking the PR on this.

@andrewstucki
Copy link
Contributor Author

nit: I noticed that some abbreviations (tcp, udp) could be written with uppercase. Not blocking the PR on this.

Thanks, yeah, I want to circle back and update some of the verbage for each of these packages to make them easier to read, but figured I could do a pass in a follow-up PR for most of these modules since the bulk of the work is figuring out the pipelines, fields, and documentation

@andrewstucki andrewstucki merged commit 6603534 into elastic:master Aug 6, 2020
@andrewstucki andrewstucki deleted the fortinet branch August 6, 2020 13:36
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@andrewstucki
Fortinet/Firewall Filebeat Module (elastic#228)
2c52235 
* add fortinet fortigate package

* update fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Team:Integrations Label for the Integrations team Team:SIEM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrewstucki @elasticmachine @mtojek