Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AbuseCH] Adds new ECS fields #2293

Merged
merged 3 commits into from
Dec 8, 2021
Merged

[AbuseCH] Adds new ECS fields #2293

merged 3 commits into from
Dec 8, 2021

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Dec 1, 2021 •
edited
Loading

What does this PR do?

Adds threat.feed.name and threat.feed.dashboard_id ECS fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@P1llus P1llus requested a review from a team December 1, 2021 10:30
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Dec 1, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-07T09:07:30.880+0000

  • Duration: 18 min 56 sec

  • Commit: b7365b3

Test stats 🧪

Test Results
Failed 0
Passed 18
Skipped 0
Total 18

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Dec 3, 2021

Are these fields in ECS? I couldn't find them.

@P1llus
Copy link
Member Author

P1llus commented Dec 6, 2021

Are these fields in ECS? I couldn't find them.

They are not in ECS yet, but are coming. We will need to add them for 8.0 either way currently.

@P1llus P1llus merged commit b420864 into elastic:master Dec 8, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@P1llus
[AbuseCH] Adds new ECS fields (elastic#2293)
70ff3af 
* add threat feed name and dashboard_id

* update changelog

* update fields to constant keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 left review comments

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@P1llus @elasticmachine @efd6 @andrewkroh