Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Anomali] Fixing typos in base-fields.yml #2330

Merged
merged 2 commits into from
Dec 13, 2021
Merged

[Anomali] Fixing typos in base-fields.yml #2330

merged 2 commits into from
Dec 13, 2021

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Dec 13, 2021 •
edited
Loading

What does this PR do?

Fixing some minor typos when setting TI related ECS fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@P1llus P1llus requested a review from r00tu53r December 13, 2021 06:04
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

r00tu53r
r00tu53r approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@r00tu53r r00tu53r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link

elasticmachine commented Dec 13, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-13T06:05:50.594+0000

  • Duration: 18 min 37 sec

  • Commit: 5ef25dd

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@P1llus P1llus merged commit 116d436 into elastic:master Dec 13, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@P1llus
[Anomali] Fixing typos in base-fields.yml (elastic#2330)
f9e8b89 
* fixing typos for anomali

* update docs and changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r00tu53r r00tu53r r00tu53r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@P1llus @elasticmachine @r00tu53r