[cisco_ios] Add syslog header and timestamp parsing #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
bug
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
force-pushed
the
cisco_ios/fix-syslog-parsing
branch
from
e2841c6
to
63f40fd
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Improve Cisco IOS handling for syslog data. Previously the `@timestamp` value was not being set from the timestamp in log. I tested with various time configurations. My preferred format is `service timestamps log datetime msec year show-timezone`. Fixes elastic#2474
andrewkroh
force-pushed
the
cisco_ios/fix-syslog-parsing
branch
from
63f40fd
to
459746e
Compare
efd6
reviewed
Jan 9, 2022
packages/cisco_ios/data_stream/log/_dev/test/pipeline/test-date-format.log
Show resolved
Hide resolved
andrewkroh
commented
Jan 10, 2022
| ] | ||
| }, | ||
| { | ||
| "@timestamp": "2022-01-16T22:11:43.000Z", |
There was a problem hiding this comment.
This value is wrong and I have created an issue with Elasticsearch to investigate. elastic/elasticsearch#82370
There was a problem hiding this comment.
It only affects users if they do not specify a year in their Cisco dates. I don't think this should hold up the PR.
eyalkraft
pushed a commit
to build-security/integrations
that referenced
this pull request
Mar 30, 2022
Improve Cisco IOS handling for syslog data. Previously the `@timestamp` value was not being set from the timestamp in log. I tested with various time configurations. My preferred format is `service timestamps log datetime msec year show-timezone`. Fixes elastic#2474
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve Cisco IOS handling for syslog data. Previously the
@timestampvalue was not being set from the timestamp in log.I tested with various time configurations. My preferred format is
service timestamps log datetime msec year show-timezone.Fixes #2474
Checklist
changelog.ymlfile.Related issues