Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cisco ASA] Add event codes 113029-113040 #2535

Merged
merged 6 commits into from
Feb 23, 2022

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Jan 14, 2022

What does this PR do?

Add parsing for event codes 113029 - 113040

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Jan 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-23T04:41:19.667+0000

  • Duration: 24 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 27
Skipped 0
Total 27

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Jan 16, 2022

/test

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
Copy link
Contributor

efd6 commented Feb 14, 2022

Would you mind regenerating the *-expected.json files with the current elastic-package version to get the fields in to canonical ordering to reduce future diff noise?

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after version bump change.

packages/cisco_asa/changelog.yml Outdated Show resolved Hide resolved
@efd6 efd6 merged commit 85b5ee1 into elastic:main Feb 23, 2022
@legoguy1000 legoguy1000 deleted the 2520-asa-code-113039 branch February 23, 2022 13:26
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
* 2520: Add event codes 113029-113040

* update changelog

* update generated data

* update generated data

* change version

* mark as enhancement

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cisco ASA | event.code 113039
5 participants