Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cloudwatch metrics and logs default to false #2536

Merged
merged 3 commits into from
Jan 19, 2022
Merged

Change cloudwatch metrics and logs default to false #2536

merged 3 commits into from
Jan 19, 2022

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jan 14, 2022

What does this PR do?

Cloudwatch metrics should be disabled by default because the sample configuration is to collect some EC2 metrics purely to show how users can use this data stream to collect CloudWatch metrics from any service. When user adds AWS integration and keeps all data streams that are enabled by default, then EC2 metrics will be collected twice from the EC2 data stream and the cloudwatch data stream.

Also for cloudwatch logs, this data stream is the way for users to collect any logs that are stored in CloudWatch log groups/streams as a generic input. I think we should have it disabled by default.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Screenshots

Screen Shot 2022-01-14 at 3 40 13 PM

Screen Shot 2022-01-14 at 4 03 25 PM

@elasticmachine
Copy link

elasticmachine commented Jan 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-19T15:41:23.100+0000

  • Duration: 29 min 53 sec

  • Commit: 8dc2cb9

Test stats 🧪

Test Results
Failed 0
Passed 323
Skipped 0
Total 323

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kaiyan-sheng kaiyan-sheng self-assigned this Jan 14, 2022
@kaiyan-sheng kaiyan-sheng added the Team:Integrations Label for the Integrations team label Jan 14, 2022
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@kaiyan-sheng kaiyan-sheng merged commit c1ae4d6 into elastic:master Jan 19, 2022
@kaiyan-sheng kaiyan-sheng deleted the cloudwatch_metrics_default branch January 19, 2022 19:07
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants