Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[suricata] Fix missing destination.ip #2564

Merged
merged 9 commits into from
Jan 26, 2022
Merged

[suricata] Fix missing destination.ip #2564

merged 9 commits into from
Jan 26, 2022

Conversation

andrewkroh
Copy link
Member

What does this PR do?

  • Remove event.ingested
  • Use allowed geoip test IPs in test logs
  • Use convert processor to set source/destination.ip
  • Format MAC addresses per RFC 7042 and ECS
  • Don't override event.{created,original} when reindexing
  • Use triple braces in templates or set.copy_from

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@andrewkroh andrewkroh added bug Something isn't working Integration:Suricata labels Jan 24, 2022
@elasticmachine
Copy link

elasticmachine commented Jan 24, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-26T20:16:24.957+0000

  • Duration: 15 min 46 sec

  • Commit: b1413a0

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

efd6
efd6 approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take the opportunity to normalise field order?

@andrewkroh
Copy link
Member Author

I must need to update my elastic-package. 💡 Will do that.

@andrewkroh andrewkroh merged commit ae1bb59 into elastic:main Jan 26, 2022
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@andrewkroh
[suricata] Fix missing destination.ip (elastic#2564)
478ee8c 
* Regenerate pipeline test events

* Remove event.ingested

* Use allowed geoip test IPs in test logs

* Use convert processor to set source/destination.ip

* Format MAC addresses per RFC 7042 and ECS

* Don't override event.{created,original} when reindexing

* Use triple braces in templates or set.copy_from

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Integration:Suricata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[suricata] destination.ip not set from destination.address
3 participants
@andrewkroh @elasticmachine @efd6