Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Prometheus default datastream enablement #2619

Merged
merged 2 commits into from
Jan 31, 2022
Merged

Improve Prometheus default datastream enablement #2619

merged 2 commits into from
Jan 31, 2022

Conversation

ChrsMark
Copy link
Member

What does this PR do?

Disable query and remote_write datastreams from defaults. Leaving only collector datastream enabled by default.

@ChrsMark
Improve Prometheus default datastream enablement
861a6d5 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark added the Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team label Jan 31, 2022
@ChrsMark ChrsMark self-assigned this Jan 31, 2022
@ChrsMark
Add PR number
bc07bee 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@elasticmachine
Copy link

elasticmachine commented Jan 31, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-01-31T11:25:21.266+0000

  • Duration: 20 min 38 sec

  • Commit: bc07bee

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

MichaelKatsoulis
MichaelKatsoulis approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@MichaelKatsoulis MichaelKatsoulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this package GA at some point @ChrsMark ?

@MichaelKatsoulis MichaelKatsoulis mentioned this pull request Jan 31, 2022
Closed
@ChrsMark ChrsMark merged commit 1bbccd9 into elastic:main Jan 31, 2022
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@ChrsMark
Improve Prometheus default datastream enablement (elastic#2619)
55593e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelKatsoulis MichaelKatsoulis MichaelKatsoulis approved these changes

Assignees

@ChrsMark ChrsMark

Labels
Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChrsMark @elasticmachine @MichaelKatsoulis