Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[netskope] Add Netskope package #2638

Merged
merged 4 commits into from
Feb 24, 2022

Conversation

vinit-chauhan
Copy link
Contributor

What does this PR do?

  • Generated the skeleton of the Netskpope integration package.
  • Added 2 data streams (Alert and Events).
  • Added data collection logic for both of the data streams.
  • Added the ingest pipeline for both data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files
  • Added dashboards and visualizations.
  • Added test for pipeline for the data streams.
  • Added system test cases for the data streams.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.16.2).

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/netskope directory.
  • Run the following command to run tests.

elastic-package test

Screenshots

image
image
image
image

@elasticmachine
Copy link

elasticmachine commented Feb 3, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-23T17:11:58.857+0000

  • Duration: 21 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 110
Skipped 0
Total 110

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh
Copy link
Member

/test

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 👍

packages/netskope/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/netskope/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/netskope/manifest.yml Outdated Show resolved Hide resolved
- Bump up the kibana version constraint for 7.x ( now it's 7.17.0 )
- Addressed couple of changes in README.md
@andrewkroh
Copy link
Member

/test

@andrewkroh andrewkroh merged commit 640b07d into elastic:main Feb 24, 2022
@jamiehynds jamiehynds mentioned this pull request Mar 1, 2022
15 tasks
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
- Generated the skeleton of the Netskpope integration package.
- Added 2 data streams (Alert and Events).
- Added data collection logic for both of the data streams.
- Added the ingest pipeline for both data streams.
- Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files
- Added dashboards and visualizations.
- Added test for pipeline for the data streams.
- Added system test cases for the data streams.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants