Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network_traffic: fix typo #2648

Merged
merged 3 commits into from
Feb 8, 2022
Merged

network_traffic: fix typo #2648

merged 3 commits into from
Feb 8, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Feb 8, 2022

What does this PR do?

This fixes a typo.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

elastic-package test in network_traffic.

Related issues

Screenshots

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Feb 8, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-08T21:20:23.962+0000

  • Duration: 75 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 134
Skipped 0
Total 134

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove default_field (and default_fields) entirely because it has no use within Fleet packages.

@efd6
Copy link
Contributor Author

efd6 commented Feb 8, 2022

I'll do that for this package and follow up for others with an issue.

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
@efd6 efd6 merged commit b83b6bd into elastic:main Feb 8, 2022
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.1-candidate bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants