Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crowdstrike] Fix issue with 'Is FDR Queue' option not taking effect #2653

Merged
merged 1 commit into from
Feb 9, 2022
Merged

[crowdstrike] Fix issue with 'Is FDR Queue' option not taking effect #2653

merged 1 commit into from
Feb 9, 2022

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Feb 9, 2022 •
edited
Loading

What does this PR do?

When "Is FDR Queue" was enabled in the config then the S3 input was supposed
to parse the CrowdStrike FDR SQS notification format. But the config was checking
for if fdr_queue but the variable is named is_fdr_queue.

Fixes #2646

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@andrewkroh
Fix issue with 'Is FDR Queue' option not taking effect
1add6a9 
When "Is FDR Queue" was enabled in the config then the S3 input was supposed
to parse the CrowdStrike FDR SQS notification format. But the config was checking
for `if fdr_queue` but the variable is named `is_fdr_queue`.

Fixes elastic#2646
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh added the bug Something isn't working label Feb 9, 2022
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-09T00:11:31.308+0000

  • Duration: 22 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 13
Skipped 0
Total 13

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@andrewkroh andrewkroh merged commit 0b63b55 into elastic:main Feb 9, 2022
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@andrewkroh
Fix issue with 'Is FDR Queue' option not taking effect (elastic#2653)
e368816 
When "Is FDR Queue" was enabled in the config then the S3 input was supposed
to parse the CrowdStrike FDR SQS notification format. But the config was checking
for `if fdr_queue` but the variable is named `is_fdr_queue`.

Fixes elastic#2646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-gr marc-gr marc-gr approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Integration:Crowdstrike
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[crowdstrike] 'Is FDR queue' option not being honored
3 participants
@andrewkroh @elasticmachine @marc-gr