Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[github] Fix Github query operator error #2664

Merged
merged 5 commits into from
Feb 11, 2022
Merged

[github] Fix Github query operator error #2664

merged 5 commits into from
Feb 11, 2022

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Feb 10, 2022 •
edited
Loading

What does this PR do?

Fixes an bug with an invalid query parameter operator for the GitHub API.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Feb 10, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-11T02:38:27.910+0000

  • Duration: 23 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

andrewkroh
andrewkroh approved these changes Feb 10, 2022
View reviewed changes
packages/github/_dev/build/docs/README.md Outdated Show resolved Hide resolved
@andrewkroh andrewkroh added bug Something isn't working Integration:Github Github Integration Team:Security-External Integrations labels Feb 10, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh changed the title [GitHub] Fix GIthub query operator error [github] Fix GIthub query operator error Feb 10, 2022
@andrewkroh andrewkroh changed the title [github] Fix GIthub query operator error [github] Fix Github query operator error Feb 10, 2022
@andrewkroh
Copy link
Member

/test

andrewkroh
andrewkroh approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@andrewkroh andrewkroh merged commit a4c7d8a into elastic:main Feb 11, 2022
@legoguy1000 legoguy1000 deleted the 2622-github-typo branch February 11, 2022 05:23
@andrewkroh andrewkroh mentioned this pull request Feb 11, 2022
Merged
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@legoguy1000 @andrewkroh
[github] Fix Github query operator error (elastic#2664)
e1ce655 
* elastic#2622 Fix GIthub Error

* update changelog

* add note about github enterprise

* Apply suggestions from code review

* Update config.yml

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Integration:Github Github Integration
Projects
None yet
Milestone
No milestone
3 participants
@legoguy1000 @elasticmachine @andrewkroh