-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[crowdstrike] Fix multi-line string handling for config variable #2701
Merged
andrewkroh
merged 1 commit into
elastic:main
from
andrewkroh:crowdstrike/bugfix/fdr-parse-script-yaml
Feb 16, 2022
Merged
[crowdstrike] Fix multi-line string handling for config variable #2701
andrewkroh
merged 1 commit into
elastic:main
from
andrewkroh:crowdstrike/bugfix/fdr-parse-script-yaml
Feb 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
225ff2f
to
7689cd0
Compare
7689cd0
to
65a8256
Compare
The default value for `fdr_parsing_script` is a multline string. When the handlebar template was evaluated this created invalid YAML. By changing the variable type to 'yaml' Kibana produces config that is valid. It looks like sqs.notification_parsing_script.source: >- function parse(n) { var m = JSON.parse(n); var evts = []; var files = m.files; ... I cannot find any documentation for the 'yaml' variable type so I hoping this is how it was expected to be used. Fixes elastic#2646
65a8256
to
7d13272
Compare
efd6
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mod knowing that this is how it's supposed to be used.
This was referenced Feb 16, 2022
eyalkraft
pushed a commit
to build-security/integrations
that referenced
this pull request
Mar 30, 2022
The default value for `fdr_parsing_script` is a multline string. When the handlebar template was evaluated this created invalid YAML. By changing the variable type to 'yaml' Kibana produces config that is valid. It looks like sqs.notification_parsing_script.source: >- function parse(n) { var m = JSON.parse(n); var evts = []; var files = m.files; ... I cannot find any documentation for the 'yaml' variable type so I hoping this is how it was expected to be used. Fixes elastic#2646
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The default value for
fdr_parsing_script
is a multline string. When the handlebartemplate was evaluated this created invalid YAML. By changing the variable type to
'yaml' Kibana produces config that is valid. It looks like
I cannot find any documentation for the 'yaml' variable type so I hoping this is how it was
expected to be used.
Checklist
changelog.yml
file.Related issues
Screenshots
Before:
![Screen Shot 2022-02-15 at 5 40 43 PM](https://user-images.githubusercontent.com/4565752/154167550-c1d50c20-4948-4511-8643-6326368927e4.png)
After:
![Screen Shot 2022-02-15 at 5 46 13 PM](https://user-images.githubusercontent.com/4565752/154167526-e02fa1da-bfc4-4a2d-888c-af0e7addd93d.png)