Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gcp] Remove emtpy values, names with only dots, and invalid client IPs. #2747

Merged
merged 4 commits into from
Mar 2, 2022

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Feb 28, 2022

What does this PR do?

Some gcp events contain keys that are formed only by dots, and also can contain invalid ip fields. This change cleans up both.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@elasticmachine
Copy link

elasticmachine commented Feb 28, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-02T09:40:36.278+0000

  • Duration: 27 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 28
Skipped 0
Total 28

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@marc-gr marc-gr requested a review from P1llus March 1, 2022 10:54
packages/gcp/data_stream/audit/fields/fields.yml Outdated Show resolved Hide resolved
@marc-gr marc-gr merged commit 0136946 into elastic:main Mar 2, 2022
@marc-gr marc-gr deleted the fix_gcp branch March 2, 2022 10:09
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
…Ps. (elastic#2747)

* Remove emtpy values, names with only dots, and invalid client IPs.

* Keep raw client ip, add description, and override orchestrator fields

* Re generate README.md

* Remove newlines from field descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants