Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okta: increase API response limit #2791

Merged
merged 1 commit into from Mar 9, 2022
Merged

okta: increase API response limit #2791

merged 1 commit into from Mar 9, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 9, 2022

What does this PR do?

This increases the limit for the number of results returned in an API response from okta. This allows more responses to be obtained within the API rate limits.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Should this be made a user facing option defaulting to 1000?

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 requested a review from a team as a code owner March 9, 2022 03:42
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Mar 9, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview [preview](https://ci-stats.elastic.co/app/apm/services/beats-ci/transactions/view?rangeFrom=2022-03-09T03:34:04.332Z&rangeTo=2022-03-09T03:54:04.332Z&transactionName=BUILD Ingest-manager/integrations/PR-{number}&transactionType=job&latencyAggregationType=avg&traceId=78096ac80a6747e22fed209746b93419&transactionId=1fa0d19ce41fb96c)

Expand to view the summary

Build stats

  • Start Time: 2022-03-09T03:44:04.332+0000

  • Duration: 12 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@marc-gr
Copy link
Contributor

marc-gr commented Mar 9, 2022

LGTM, just regarding:

Should this be made a user facing option defaulting to 1000?

I am good having it as a hard coded value as far as it does not affect performance in the general case. But exposing it could add flexibility if some users face issues with it I guess.

@efd6
Copy link
Contributor Author

efd6 commented Mar 9, 2022

We can always add a config option in the future if someone asks for it; harder to take it away if it causes problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[okta] Increase 'limit' value to reduce number of requests
3 participants