Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cef to ECS 8.2 #2804

Merged
merged 7 commits into from
Apr 25, 2022
Merged

Update cef to ECS 8.2 #2804

merged 7 commits into from
Apr 25, 2022

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Mar 9, 2022 •
edited
Loading

Upgrades cef to ECS 8.2.

@taylor-swanson
Update cef to ECS 8.2
cddc855 
- Breaking change: remapping email ECS fields
@taylor-swanson taylor-swanson self-assigned this Mar 9, 2022
@taylor-swanson taylor-swanson mentioned this pull request Mar 9, 2022
Closed
@elasticmachine
Copy link

elasticmachine commented Mar 9, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-21T16:39:38.890+0000

  • Duration: 14 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 84
Skipped 0
Total 84

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@taylor-swanson taylor-swanson marked this pull request as ready for review March 10, 2022 15:33
@taylor-swanson taylor-swanson requested a review from a team as a code owner March 10, 2022 15:33
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

andrewkroh
andrewkroh reviewed Mar 15, 2022
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I improved the pipeline tests for CEF so there are some conflicts. But hopefully this enables you to test your changes.

packages/cef/changelog.yml Outdated Show resolved Hide resolved
packages/cef/data_stream/log/elasticsearch/ingest_pipeline/cp-pipeline.yml Outdated Show resolved Hide resolved
packages/cef/data_stream/log/elasticsearch/ingest_pipeline/cp-pipeline.yml Outdated Show resolved Hide resolved
packages/cef/data_stream/log/elasticsearch/ingest_pipeline/cp-pipeline.yml Outdated Show resolved Hide resolved
packages/cef/data_stream/log/elasticsearch/ingest_pipeline/cp-pipeline.yml Outdated Show resolved Hide resolved
packages/cef/data_stream/log/elasticsearch/ingest_pipeline/cp-pipeline.yml Outdated Show resolved Hide resolved
packages/cef/changelog.yml Outdated Show resolved Hide resolved
epixa
epixa reviewed Mar 18, 2022
View reviewed changes
packages/cef/manifest.yml Outdated Show resolved Hide resolved
@taylor-swanson
Make changes be minor
c4a46cc 
- Copy values to new ECS fields and retain older fields for now
- Version bump is now minor
- Remove obsolete expected files
- Regen README
@taylor-swanson taylor-swanson merged commit b249c92 into elastic:main Apr 25, 2022
@taylor-swanson taylor-swanson deleted the ecs8.2-cef branch April 25, 2022 12:55
@andrewkroh andrewkroh mentioned this pull request May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epixa epixa epixa left review comments

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
enhancement New feature or request Integration:CEF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taylor-swanson @elasticmachine @epixa @andrewkroh