Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[m365_defender] New Package #2854

Merged
merged 7 commits into from
Mar 23, 2022
Merged

[m365_defender] New Package #2854

merged 7 commits into from
Mar 23, 2022

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Mar 21, 2022 •
edited
Loading

What does this PR do?

This copies over the m365_defender filebeat fileset over to its own package, with some smaller modifications.

Integration has been tested manually as well by myself.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Screenshots

Overview:
image

Settings:
image

Related Issues

Closes #936

@P1llus P1llus requested a review from a team March 21, 2022 12:23
@P1llus P1llus requested a review from a team as a code owner March 21, 2022 12:23
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Mar 21, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-22T20:14:32.879+0000

  • Duration: 13 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 6
Skipped 0
Total 6

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

mtojek
mtojek approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODEOWNERS is valid.

@P1llus P1llus requested a review from a team March 21, 2022 14:42
adriansr
adriansr suggested changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions and small things.

packages/m365_defender/data_stream/log/agent/stream/httpjson.yml.hbs Outdated Show resolved Hide resolved
packages/m365_defender/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/m365_defender/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/m365_defender/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/m365_defender/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/m365_defender/data_stream/log/fields/fields.yml Outdated Show resolved Hide resolved
@P1llus P1llus requested a review from adriansr March 22, 2022 08:24
@andrewkroh
Copy link
Member

Relates: #936

@andrewkroh andrewkroh linked an issue Mar 22, 2022 that may be closed by this pull request
Migrate Microsoft M365 Defender module #936
Closed
13 tasks
adriansr
adriansr approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P1llus P1llus merged commit 1195234 into elastic:main Mar 23, 2022
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@P1llus @adriansr
[m365_defender] New Package (elastic#2854)
c421ee6 
* Initial release of m365_defender package

* update logo

* changelog

* Update codeowners

* adding null checks for comments

* Update packages/m365_defender/data_stream/log/agent/stream/httpjson.yml.hbs

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>

* update pipeline and descriptions

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-gr marc-gr marc-gr left review comments

@mtojek mtojek mtojek approved these changes

@adriansr adriansr adriansr approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Microsoft M365 Defender module
6 participants
@P1llus @elasticmachine @andrewkroh @mtojek @adriansr @marc-gr