Extract potential host.domain and user.domain in Cisco Secure Endpoint #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@P1llus please test :) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
I added some small additions to it, some extra failure checks in the scripts, ran the CI generation of test data, and ensured that both host fields are still set. Just need another to review then I can merge. |
|
/test |
efd6
reviewed
Mar 25, 2022
There was a problem hiding this comment.
Remove event.ingested at https://github.com/elastic/integrations/pull/2888/files#diff-f430f71598ebb4c703c61a0500ebad83a87feee76e6f33c9ec8720576574e01eR38-R40?
None of the host.domain fields have any value other than "".
packages/cisco_secure_endpoint/data_stream/event/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
|
/test |
eyalkraft
pushed a commit
to build-security/integrations
that referenced
this pull request
Mar 30, 2022
elastic#2888) * Extract potential host.domain and user.domain * Bump version to 2.0.1 Bump version * Update changelog.yml * Fixes Needed to use cisco.secure_endpoint.computer.hostname instead of host.name * updating CI tests and adding some minor changes * adding some small modifications to pipeline * adding some small changes based on PR review * update docs Co-authored-by: Marius Iversen <marius.iversen@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Will try to extract host.domain, user.domain and user.email if possible.
Checklist
changelog.ymlfile.