Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TI AbuseCH] Fix field mappings #2893

Merged
merged 2 commits into from
Mar 28, 2022
Merged

[TI AbuseCH] Fix field mappings #2893

merged 2 commits into from
Mar 28, 2022

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Fix field mapping conflicts in threat.indicator.file.x509.not_before/not_after

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 requested a review from a team as a code owner March 26, 2022 18:47
@elasticmachine
Copy link

elasticmachine commented Mar 26, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-28T00:35:23.257+0000

  • Duration: 14 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 18
Skipped 0
Total 18

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Mar 28, 2022

/test

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh merged commit d543323 into elastic:main Mar 28, 2022
@legoguy1000 legoguy1000 deleted the 2871-ti_abusech-field-conflicts branch March 28, 2022 21:13
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@legoguy1000
[TI AbuseCH] Fix field mappings (elastic#2893)
1b1d663 
Fix field mapping conflicts in threat.indicator.file.x509.not_before/not_after.
@andrewkroh andrewkroh mentioned this pull request Apr 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Integration:AbuseCH
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ti_abusech] Conflicting threat.indicator.file.x509.not_before/not_after definition
4 participants
@legoguy1000 @elasticmachine @efd6 @andrewkroh