Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Cisco FTD readme #2931

Merged
merged 12 commits into from May 2, 2022
Merged

update Cisco FTD readme #2931

merged 12 commits into from May 2, 2022

Conversation

cherryleaf
Copy link
Contributor

@cherryleaf cherryleaf commented Mar 30, 2022 •
edited

Added link to Cisco's FTD documentation

Type of change

  • Enhancement

What does this PR do?

Added link to Cisco's FTD documentation

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@cherryleaf
update readme
804c8d2 
Added link to Cisco's FTD documentation
@cherryleaf cherryleaf requested a review from a team as a code owner March 30, 2022 13:43
@elasticmachine
Copy link

elasticmachine commented Mar 30, 2022 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-02T22:18:23.529+0000

  • Duration: 15 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 17
Skipped 0
Total 17

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh added the Integration:CiscoFTD Cisco FTD Firepower Threat Defense label Apr 6, 2022
@r00tu53r r00tu53r added the documentation Improvements or additions to documentation label Apr 12, 2022
ellis-elastic and others added 4 commits April 28, 2022 10:12
@ellis-elastic
Update readme
63996f7 
added extra information on where to find information on configuration.
@ellis-elastic
ran build
68640de
@ellis-elastic
Update Changelog
02a8f0c 
to resolve version conflict with other PR
@ellis-elastic
Merge branch 'main' into cisco_ftd-docs
473d828
@ellis-elastic @r00tu53r
Update packages/cisco_ftd/_dev/build/docs/README.md
a280d41 
Co-authored-by: Sai Kiran <85323324+r00tu53r@users.noreply.github.com>
@r00tu53r
Copy link
Contributor

/test

r00tu53r
r00tu53r approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@r00tu53r r00tu53r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.21
Classes 100.0% (1/1) 💚 3.21
Methods 100.0% (17/17) 💚 11.72
Lines 66.522% (1073/1613) 👎 -22.378
Conditionals 100.0% (0/0) 💚

@bmorelli25 bmorelli25 merged commit 3209757 into elastic:main May 2, 2022
@andrewkroh andrewkroh mentioned this pull request May 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellis-elastic ellis-elastic ellis-elastic left review comments

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@r00tu53r r00tu53r r00tu53r approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation Integration:CiscoFTD Cisco FTD Firepower Threat Defense
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cherryleaf @elasticmachine @r00tu53r @bmorelli25 @ellis-elastic @andrewkroh @efd6