[hashicorp_vault] Clarify dynamic mapping for hashicorp_vault.metrics #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
bug
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Remove named mappings and depend on the dynamic mappings. Dynamic mappings were already present, but elastic-package doesn't honor those during field validation. So this specifies a hashicorp_vault.metrics.*.* mapping for the express purpose of making elastic-package field validation pass. Fixes elastic#2898
andrewkroh
force-pushed
the
hashicorp_vault/bugfix/dynamic-metric-fields
branch
from
331e9b8
to
55aff62
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
efd6
approved these changes
Apr 4, 2022
This was referenced Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove named mappings and depend on the dynamic mappings. Dynamic mappings
were already present, but elastic-package doesn't honor those during field validation.
So this specifies a
hashicorp_vault.metrics.*.*mapping for the express purpose of makingelastic-package field validation pass.
Fixes #2898
Checklist
changelog.ymlfile.Related issues