Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Netflow readme #3002

Merged
merged 26 commits into from
Aug 15, 2022
Merged

Update Netflow readme #3002

merged 26 commits into from
Aug 15, 2022

Conversation

cherryleaf
Copy link
Contributor

@cherryleaf cherryleaf commented Apr 5, 2022 •
edited
Loading

Type of change

  • Enhancement

What does this PR do?

Tidy up of Markdown in Readme.md, including adding link to developer's documentation, if missing

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

GinnyGalicia and others added 7 commits March 10, 2022 13:27
@GinnyGalicia
Update README.md
17bf8c1 
Changed headings to correct markdown syntax
@dependabot
Bump github.com/stretchr/testify from 1.7.0 to 1.7.1
0b2fc35 
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.7.0...v1.7.1)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@GinnyGalicia
Markdown tidy up of readme file
cd6e46d 
Markdown tidy up of readme file
@GinnyGalicia
Update readme
e9aad4e 
To avoid clashes
@GinnyGalicia
update to reset main
07f3de3 
update to reset main branch and stop files being added to PRs
@GinnyGalicia
reset to main build
fb2f512
@GinnyGalicia
update readme
2cdd3bb 
Tidy up of Markdown in Readme.md, including adding link to developer's documentation, if missing
@cherryleaf cherryleaf requested a review from a team as a code owner April 5, 2022 14:34
@elasticmachine
Copy link

elasticmachine commented Apr 5, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-15T14:52:52.920+0000

  • Duration: 20 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 92
Skipped 0
Total 92

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

dependabot bot and others added 9 commits April 5, 2022 14:40
@dependabot
Bump github.com/elastic/package-registry from 1.7.0 to 1.8.0
fc18bec 
Bumps [github.com/elastic/package-registry](https://github.com/elastic/package-registry) from 1.7.0 to 1.8.0.
- [Release notes](https://github.com/elastic/package-registry/releases)
- [Changelog](https://github.com/elastic/package-registry/blob/main/CHANGELOG.md)
- [Commits](elastic/package-registry@v1.7.0...v1.8.0)

---
updated-dependencies:
- dependency-name: github.com/elastic/package-registry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@GinnyGalicia
Update changelog
ba3503c
@GinnyGalicia
Update README.md
830cfdc
@GinnyGalicia
Merge pull request #6 from GinnyGalicia/dependabot/go_modules/github.…
f7759ab 
…com/elastic/package-registry-1.8.0

Bump github.com/elastic/package-registry from 1.7.0 to 1.8.0
@GinnyGalicia
Merge pull request #2 from GinnyGalicia/dependabot/go_modules/github.…
f675166 
…com/stretchr/testify-1.7.1

Bump github.com/stretchr/testify from 1.7.0 to 1.7.1
@dependabot
Bump github.com/magefile/mage from 1.11.0 to 1.13.0
52b1559 
Bumps [github.com/magefile/mage](https://github.com/magefile/mage) from 1.11.0 to 1.13.0.
- [Release notes](https://github.com/magefile/mage/releases)
- [Changelog](https://github.com/magefile/mage/blob/master/.goreleaser.yml)
- [Commits](magefile/mage@v1.11.0...v1.13.0)

---
updated-dependencies:
- dependency-name: github.com/magefile/mage
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@GinnyGalicia
Merge pull request #3 from GinnyGalicia/dependabot/go_modules/github.…
101ca85 
…com/magefile/mage-1.13.0

Bump github.com/magefile/mage from 1.11.0 to 1.13.0
@dependabot
Bump github.com/elastic/elastic-package from 0.38.0 to 0.46.0
0e2b24c 
Bumps [github.com/elastic/elastic-package](https://github.com/elastic/elastic-package) from 0.38.0 to 0.46.0.
- [Release notes](https://github.com/elastic/elastic-package/releases)
- [Changelog](https://github.com/elastic/elastic-package/blob/main/.goreleaser.yml)
- [Commits](elastic/elastic-package@v0.38.0...v0.46.0)

---
updated-dependencies:
- dependency-name: github.com/elastic/elastic-package
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@GinnyGalicia
Merge pull request #7 from GinnyGalicia/dependabot/go_modules/github.…
0490a16 
…com/elastic/elastic-package-0.46.0

Bump github.com/elastic/elastic-package from 0.38.0 to 0.46.0
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@bmorelli25
Copy link
Member

/test

@GinnyGalicia @bmorelli25
Update packages/netflow/changelog.yml
5a5a7ea 
Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
efd6
efd6 requested changes Apr 12, 2022
View reviewed changes
packages/1password/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/netflow/changelog.yml Outdated Show resolved Hide resolved
@r00tu53r r00tu53r added the documentation Improvements or additions to documentation label Apr 12, 2022
@efd6
Copy link
Contributor

efd6 commented Apr 13, 2022

/test

@andrewkroh andrewkroh added the conflicts There is a conflict in the backported pull request label Jul 20, 2022
@efd6
Copy link
Contributor

efd6 commented Aug 10, 2022

/test

@andrewkroh
Copy link
Member

README.md is outdated. Rebuild the package with 'elastic-package build'
[2022-08-10T04:03:55.675Z] Error: checking package failed: checking readme files are up-to-date failed: checking readme files are up-to-date failed

@GinnyGalicia can you please regenerate the README file with elastic-package build.

@GinnyGalicia
Copy link
Contributor

Ran build again

@andrewkroh
Copy link
Member

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.941
Classes 100.0% (1/1) 💚 2.941
Methods 100.0% (7/7) 💚 10.5
Lines 100.0% (56/56) 💚 8.472
Conditionals 100.0% (0/0) 💚

@andrewkroh andrewkroh merged commit 7c181cc into elastic:main Aug 15, 2022
@andrewkroh andrewkroh mentioned this pull request Aug 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 left review comments

@efd6 efd6 efd6 requested changes

@GinnyGalicia GinnyGalicia GinnyGalicia left review comments

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
conflicts There is a conflict in the backported pull request documentation Improvements or additions to documentation Integration:netflow NetFlow Records
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@cherryleaf @elasticmachine @bmorelli25 @efd6 @andrewkroh @GinnyGalicia @r00tu53r @ellis-elastic