Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cisco,cisco_duo,cisco_ftd: fix event.outcome and event.type field values #3018

Merged
merged 7 commits into from
Apr 6, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Apr 6, 2022

What does this PR do?

This make field values agree with the allowable set according to ECS.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Apr 6, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-06T22:32:37.182+0000

  • Duration: 22 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 131
Skipped 0
Total 131

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@jsoriano
Copy link
Member

Reopening as there seems to be still issues: https://beats-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Fintegrations/detail/PR-3017/3/tests

test case failed: one or more problems with fields found in documents: [0] parsing field value failed: field "event.outcome"'s value "failed" is not one of the allowed values (failure, success, unknown)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants