Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zscaler_zia] Added Cloud NSS support to Zscaler ZIA package. #3111

Merged
merged 5 commits into from
Apr 28, 2022
Merged

[zscaler_zia] Added Cloud NSS support to Zscaler ZIA package. #3111

merged 5 commits into from
Apr 28, 2022

Conversation

vinit-chauhan
Copy link
Contributor

What does this PR do?

This PR adds support of Cloud NSS to the existing Zscaler ZIA integration package. ( Cloud NSS supports DNS, Firewall, Tunnel, and Web Logs )

  • Added a new data collection logic for the supported data streams.
  • Added the ingest pipeline for the data stream.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files
  • Added dashboards and visualizations.
  • Added test for pipeline for the data stream.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.17.0 || ^8.0.0).

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/zscaler_zia directory.
  • Run the following command to run tests.

elastic-package test

Screenshots

image
image
image

@vinit-chauhan vinit-chauhan requested a review from a team as a code owner April 15, 2022 10:59
@elasticmachine
Copy link

elasticmachine commented Apr 15, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-26T13:00:45.002+0000

  • Duration: 20 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 68
Skipped 0
Total 68

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

andrewkroh
andrewkroh reviewed Apr 15, 2022
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally lost all my original comments so tried to recreate them rather quickly so sorry if some of them are terse. Please reach out to me if you want to discuss any of them.

packages/zscaler_zia/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/zscaler_zia/_dev/deploy/docker/docker-compose.yml Outdated Show resolved Hide resolved
...ages/zscaler_zia/data_stream/dns/_dev/test/pipeline/test-dns-http_endpoint.log-expected.json Show resolved Hide resolved
...ages/zscaler_zia/data_stream/dns/_dev/test/pipeline/test-dns-http_endpoint.log-expected.json Show resolved Hide resolved
...ages/zscaler_zia/data_stream/dns/_dev/test/pipeline/test-dns-http_endpoint.log-expected.json Outdated Show resolved Hide resolved
packages/zscaler_zia/data_stream/firewall/_dev/test/pipeline/test-firewall.log-expected.json Outdated Show resolved Hide resolved
packages/zscaler_zia/data_stream/firewall/_dev/test/pipeline/test-firewall.log-expected.json Outdated Show resolved Hide resolved
packages/zscaler_zia/data_stream/firewall/_dev/test/pipeline/test-firewall.log-expected.json Show resolved Hide resolved
...scaler_zia/data_stream/tunnel/_dev/test/pipeline/test-tunnel-http_endpoint.log-expected.json Show resolved Hide resolved
packages/zscaler_zia/data_stream/web/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
@andrewkroh
Copy link
Member

/test

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@vinit-chauhan
Copy link
Contributor Author

/test

@andrewkroh
Copy link
Member

There are some conflicts to resolve.

@vinit-chauhan
Copy link
Contributor Author

Resolved the merge conflicts.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 2.941
Classes 100.0% (5/5) 💚 2.941
Methods 100.0% (66/66) 💚 12.218
Lines 94.454% (1141/1208) 👍 5.876
Conditionals 100.0% (0/0) 💚

@andrewkroh andrewkroh merged commit a771033 into elastic:main Apr 28, 2022
@andrewkroh andrewkroh mentioned this pull request May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@efd6 efd6 efd6 left review comments

Assignees
No one assigned
Labels
enhancement New feature or request Integration:zscaler_zia Zscaler Internet Access
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vinit-chauhan @elasticmachine @andrewkroh @efd6