Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update juniper SRX readme #3135

Merged
merged 4 commits into from Jun 17, 2022
Merged

update juniper SRX readme #3135

merged 4 commits into from Jun 17, 2022

Conversation

ellis-elastic
Copy link
Contributor

@ellis-elastic ellis-elastic commented Apr 20, 2022 •
edited

added link to juniper documentation

Type of change

  • Enhancement

What does this PR do?

added link to juniper documentation

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ellis-elastic
update readme
aa72b68 
added link to juniper documentation
@ellis-elastic ellis-elastic added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 20, 2022
@ellis-elastic ellis-elastic requested a review from a team as a code owner April 20, 2022 12:15
@ellis-elastic ellis-elastic marked this pull request as draft April 20, 2022 12:15
@elasticmachine
Copy link

elasticmachine commented Apr 20, 2022 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-17T08:53:49.199+0000

  • Duration: 18 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 13
Skipped 0
Total 13

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ellis-elastic ellis-elastic marked this pull request as ready for review April 21, 2022 07:03
@elasticmachine
Copy link

elasticmachine commented Apr 27, 2022 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (7/7) 💚 3.546
Classes 100.0% (7/7) 💚 3.546
Methods 100.0% (50/50) 💚 10.678
Lines 70.799% (1525/2154) 👎 -20.059
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

r00tu53r
r00tu53r approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@r00tu53r r00tu53r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ellis-elastic ellis-elastic merged commit 0e3f62c into elastic:main Jun 17, 2022
@ellis-elastic ellis-elastic deleted the Juniper-SRX-docs branch June 17, 2022 09:14
@andrewkroh andrewkroh mentioned this pull request Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@r00tu53r r00tu53r r00tu53r approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ellis-elastic @elasticmachine @bmorelli25 @r00tu53r @epixa