Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update QNAP NAS readme #3155

Merged
merged 4 commits into from
Jun 9, 2022
Merged

update QNAP NAS readme #3155

merged 4 commits into from
Jun 9, 2022

Conversation

ellis-elastic
Copy link
Contributor

@ellis-elastic ellis-elastic commented Apr 21, 2022 •
edited
Loading

added link to QNAP documentation

Type of change

  • Enhancement

What does this PR do?

added link to QNAP documentation

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ellis-elastic
update readme
675fcb6 
added link to QNAP documentation
@ellis-elastic ellis-elastic added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 21, 2022
@ellis-elastic ellis-elastic requested a review from a team as a code owner April 21, 2022 08:02
@ellis-elastic ellis-elastic marked this pull request as draft April 21, 2022 08:02
@elasticmachine
Copy link

elasticmachine commented Apr 21, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-18T13:25:25.952+0000

  • Duration: 18 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ellis-elastic ellis-elastic marked this pull request as ready for review April 22, 2022 08:19
@elasticmachine
Copy link

elasticmachine commented Apr 27, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.589
Classes 100.0% (1/1) 💚 3.589
Methods 100.0% (14/14) 💚 11.711
Lines 95.142% (235/247) 👍 6.124
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

leehinman
leehinman approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ellis-elastic ellis-elastic merged commit 3cc9030 into elastic:main Jun 9, 2022
@ellis-elastic ellis-elastic deleted the qnap_nas-docs branch June 9, 2022 10:42
@andrewkroh andrewkroh mentioned this pull request Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@leehinman leehinman leehinman approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ellis-elastic @elasticmachine @bmorelli25 @leehinman @epixa