Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Posture] Add latest findings data view #3183

Merged
merged 2 commits into from
Apr 28, 2022
Merged

[Cloud Posture] Add latest findings data view #3183

merged 2 commits into from
Apr 28, 2022

Conversation

ari-aviran
Copy link
Contributor

What does this PR do?

Add a "latest findings" data view to the CSP integrations

@ari-aviran ari-aviran added the enhancement New feature or request label Apr 25, 2022
@ari-aviran ari-aviran requested a review from a team as a code owner April 25, 2022 09:32
@ari-aviran ari-aviran added the Team:Cloud Security Label for the Cloud Security team label Apr 25, 2022
@elasticmachine
Copy link

elasticmachine commented Apr 25, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-25T11:31:56.224+0000

  • Duration: 13 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ari-aviran ari-aviran mentioned this pull request Apr 25, 2022
Merged
oren-zohar
oren-zohar reviewed Apr 25, 2022
View reviewed changes
Copy link
Contributor

@oren-zohar oren-zohar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but why are we keeping the old index-pattern? it's not working anymore

...chmark/kibana/index_pattern/cloud_security_posture-303eea10-c475-11ec-af18-c5b9b437dbbe.json
@@ -0,0 +1,14 @@
{
"attributes": {
"description": "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think we can add a description? what will it affect in Kibana?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in Kibana you can't actually add a description to a data view (index pattern) but I'll check and update the description if it makes any difference. Actually it might also be useful for self-documentation

@ari-aviran
Copy link
Contributor Author

Looks good but why are we keeping the old index-pattern? it's not working anymore

Keeping the old one for backwards compatibility, Kibana still relies on it. We'll remove the old ones once we merge the Kibana PR

@ari-aviran ari-aviran merged commit 306e7af into elastic:main Apr 28, 2022
@ari-aviran ari-aviran deleted the csp_latest_findings_data_view branch April 28, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oren-zohar oren-zohar oren-zohar left review comments

@kfirpeled kfirpeled kfirpeled approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Team:Cloud Security Label for the Cloud Security team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ari-aviran @elasticmachine @kfirpeled @oren-zohar