Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IBM WebSphere Application Server] Add WebSphere Application Server Integration Package with Session Manager data stream #3199

Merged
merged 10 commits into from
May 31, 2022
Merged

[IBM WebSphere Application Server] Add WebSphere Application Server Integration Package with Session Manager data stream #3199

merged 10 commits into from
May 31, 2022

Conversation

kush-elastic
Copy link
Collaborator

@kush-elastic kush-elastic commented Apr 26, 2022 •
edited
Loading

  • Enhancement

What does this PR do?

  • Generated the skeleton of WebSphere Application Server integration package.
  • Added 1 data stream (session_manager).
  • Added data collection logic for the data streams.
  • Added the ingest pipeline for the data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yaml files.
  • Added dashboards and visualizations.
  • Added pipeline test cases for the data stream.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/websphere_application_server directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

Screenshots

websphere_application_server-session_manager-dashboard-screenshot

This was referenced Apr 26, 2022
Merged
Merged
Merged
@kush-elastic kush-elastic changed the title Add Integration package WebSphere Application Server with Session Man… [IBM WebSphere Application Server] Add WebSphere Application Server Integration Package with Session Manager data stream Apr 26, 2022
@elasticmachine
Copy link

elasticmachine commented Apr 26, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-31T11:30:25.761+0000

  • Duration: 27 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 40
Skipped 0
Total 40

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 26, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 3.448
Classes 100.0% (4/4) 💚 3.448
Methods 100.0% (28/28) 💚 10.896
Lines 100.0% (488/488) 💚 10.4
Conditionals 100.0% (0/0) 💚

@kush-elastic kush-elastic marked this pull request as draft April 26, 2022 14:49
@kush-elastic kush-elastic mentioned this pull request Apr 29, 2022
Closed
4 tasks
@kush-elastic kush-elastic mentioned this pull request May 4, 2022
Closed
4 tasks
@kush-elastic kush-elastic added the enhancement New feature or request label May 10, 2022
@kush-elastic kush-elastic linked an issue May 11, 2022 that may be closed by this pull request
Create IBM Websphere Application Server Integration #2847
Closed
8 tasks
yug-rajani
yug-rajani suggested changes May 25, 2022
View reviewed changes
Copy link
Contributor

@yug-rajani yug-rajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes

...ta_stream/session_manager/_dev/test/pipeline/test-session-manager-metrics.json-expected.json Outdated Show resolved Hide resolved
yug-rajani
yug-rajani approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@yug-rajani yug-rajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic marked this pull request as ready for review May 26, 2022 07:35
@kush-elastic kush-elastic requested a review from a team as a code owner May 26, 2022 07:35
@kush-elastic kush-elastic merged commit 282bdf9 into elastic:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yug-rajani yug-rajani yug-rajani approved these changes

@ishleenk17 ishleenk17 ishleenk17 approved these changes

Assignees

@kush-elastic kush-elastic

Labels
enhancement New feature or request Integration:WebsphereApplicationServer New Integration Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create IBM Websphere Application Server Integration
5 participants
@kush-elastic @elasticmachine @yug-rajani @ishleenk17 @andrewkroh