Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mimecast] Add more use cases for parsing audit events #3231

Merged
merged 5 commits into from
May 10, 2022
Merged

[mimecast] Add more use cases for parsing audit events #3231

merged 5 commits into from
May 10, 2022

Conversation

djordje-adzemovic-devtech
Copy link
Contributor

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@djordje-adzemovic-devtech djordje-adzemovic-devtech requested a review from a team as a code owner April 29, 2022 11:39
@elasticmachine
Copy link

elasticmachine commented Apr 29, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-09T11:35:09.322+0000

  • Duration: 19 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 61
Skipped 0
Total 61

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented May 1, 2022

/test

@efd6
Copy link
Contributor

efd6 commented May 5, 2022

/test

@djordje-adzemovic-devtech
Copy link
Contributor Author

Can someone re-trigger tests please?

@r00tu53r
Copy link
Contributor

r00tu53r commented May 9, 2022

/test

@elasticmachine
Copy link

elasticmachine commented May 9, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 100.0% (8/8) 💚 3.597
Classes 100.0% (8/8) 💚 3.597
Methods 92.174% (106/115) 👍 3.935
Lines 83.126% (1202/1446) 👎 -5.812
Conditionals 100.0% (0/0) 💚

@efd6
Copy link
Contributor

efd6 commented May 9, 2022

/test

@djordje-adzemovic-devtech
Copy link
Contributor Author

Is it ok to be merged now?

efd6
efd6 approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit a1603c5 into elastic:main May 10, 2022
This was referenced May 22, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@djordje-adzemovic-devtech @elasticmachine @efd6 @r00tu53r