Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add message field to Zeek Syslog datastream #3264

Merged
merged 3 commits into from May 4, 2022
Merged

Add message field to Zeek Syslog datastream #3264

merged 3 commits into from May 4, 2022

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Sets the message field from the Zeek Syslog datastream. Adds sample data for pipeline and system tests.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 requested a review from a team as a code owner May 3, 2022 23:22
@elasticmachine
Copy link

elasticmachine commented May 3, 2022 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-04T12:30:13.819+0000

  • Duration: 66 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 203
Skipped 0
Total 203

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

efd6
efd6 reviewed May 4, 2022
View reviewed changes
packages/zeek/data_stream/syslog/fields/fields.yml Show resolved Hide resolved
packages/zeek/changelog.yml Outdated Show resolved Hide resolved
packages/zeek/changelog.yml Show resolved Hide resolved
@efd6
Copy link
Contributor

efd6 commented May 4, 2022

/test

@elasticmachine
Copy link

elasticmachine commented May 4, 2022 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (39/39) 💚
Files 96.154% (75/78) 👎 -0.465
Classes 96.154% (75/78) 👎 -0.465
Methods 86.486% (608/703) 👎 -1.794
Lines 93.034% (8254/8872) 👍 4.122
Conditionals 100.0% (0/0) 💚

efd6
efd6 reviewed May 4, 2022
View reviewed changes
packages/zeek/changelog.yml Outdated Show resolved Hide resolved
@legoguy1000
Copy link
Contributor Author

@efd6 updated.

@efd6
Copy link
Contributor

efd6 commented May 4, 2022

/test

efd6
efd6 approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit add2709 into elastic:main May 4, 2022
@legoguy1000 legoguy1000 deleted the 2477-zeek-message branch May 5, 2022 11:43
@andrewkroh andrewkroh mentioned this pull request May 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[zeek] Set message from zeek.syslog.message
3 participants
@legoguy1000 @elasticmachine @efd6