Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fortinet] Separate Fortinet FortiGate into own Integration #3265

Merged
merged 12 commits into from
Jul 25, 2022
Merged

[Fortinet] Separate Fortinet FortiGate into own Integration #3265

merged 12 commits into from
Jul 25, 2022

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Creates an independent integration for Fortinet FortiGate logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented May 3, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-25T00:02:55.350+0000

  • Duration: 19 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@legoguy1000 legoguy1000 changed the title Separate Fortinet FortiGate into own Integration [Fortinet_Fortigate] Separate Fortinet FortiGate into own Integration May 4, 2022
@legoguy1000 legoguy1000 changed the title [Fortinet_Fortigate] Separate Fortinet FortiGate into own Integration [Fortinet] Separate Fortinet FortiGate into own Integration May 4, 2022
@legoguy1000
Copy link
Contributor Author

@andrewkroh ready for testing

@efd6
Copy link
Contributor

efd6 commented Jun 28, 2022

/test

@efd6 efd6 added enhancement New feature or request Team:Security-External Integrations Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. labels Jun 28, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
Copy link
Contributor

efd6 commented Jun 28, 2022

/test

1 similar comment
@efd6
Copy link
Contributor

efd6 commented Jun 29, 2022

/test

@legoguy1000
Copy link
Contributor Author

I found and fixed the issues

@efd6
Copy link
Contributor

efd6 commented Jul 11, 2022

/test

@elasticmachine
Copy link

elasticmachine commented Jul 11, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚 3.03
Classes 100.0% (4/4) 💚 3.03
Methods 100.0% (38/38) 💚 10.288
Lines 91.688% (1070/1167) 👍 0.246
Conditionals 100.0% (0/0) 💚

@efd6
Copy link
Contributor

efd6 commented Jul 11, 2022

/test

@efd6
Copy link
Contributor

efd6 commented Jul 11, 2022

/test

@efd6
Copy link
Contributor

efd6 commented Jul 11, 2022

/test

@efd6
Copy link
Contributor

efd6 commented Jul 25, 2022

/test

@efd6 efd6 merged commit 248c5ba into elastic:main Jul 25, 2022
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-25T00:04:55.075+0000

  • Duration: 20 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚 3.03
Classes 100.0% (4/4) 💚 3.03
Methods 100.0% (38/38) 💚 10.288
Lines 91.688% (1070/1167) 👍 0.246
Conditionals 100.0% (0/0) 💚

@legoguy1000 legoguy1000 deleted the 1936-fortinet-fortigate branch July 25, 2022 01:25
@andrewkroh andrewkroh mentioned this pull request Jul 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@legoguy1000 @elasticmachine @efd6