Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elasticsearch] Add scope configuration option for metricsets #3275

Merged
merged 3 commits into from Jun 9, 2022

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Add scope configuration option for metricsets

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 requested a review from a team as a code owner May 4, 2022 12:28
@elasticmachine
Copy link

elasticmachine commented May 4, 2022

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-10T15:33:08.619+0000

  • Duration: 4 min 53 sec

Steps errors 2

Expand to view the steps failures

Google Storage Download
  • Took 0 min 0 sec . View more details here
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/legoguy1000 return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/legoguy1000 : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/legoguy1000 : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@andrewkroh andrewkroh changed the title Add scope configuration option for metricsets [elasticsearch] Add scope configuration option for metricsets May 5, 2022
@andrewkroh
Copy link
Member

/test

@elasticmachine
Copy link

elasticmachine commented May 12, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-09T10:04:51.131+0000

  • Duration: 13 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@legoguy1000
Copy link
Contributor Author

THe test never seemed to run for this

@klacabane klacabane self-requested a review June 8, 2022 12:32
@klacabane
Copy link
Contributor

/test

@klacabane
Copy link
Contributor

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.546
Classes 100.0% (0/0) 💚 3.546
Methods 49.057% (26/53) 👎 -40.245
Lines 100.0% (0/0) 💚 9.328
Conditionals 100.0% (0/0) 💚

@klacabane
Copy link
Contributor

Verified the property was properly injected in the agent configuration and in the metricsets (with force: set an invalid scope value and made sure this path was triggered :))

LGTM, thanks @legoguy1000

$ cat state.yml|grep scope -C 5
        id: elasticsearch/metrics-elasticsearch.cluster_stats-dd974da8-2d3f-4ac6-a504-44ce05931f1f
        metricsets:
        - cluster_stats
        password: changeme
        period: null
        scope: node
        username: elastic
      type: elasticsearch/metrics
      use_output: default
    output_permissions:
      default:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elasticsearch (Experimental) Module Doesn't have ability to set scope: cluster
4 participants