-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cassandra] Fix dashboard issues. #3287
[Cassandra] Fix dashboard issues. #3287
Conversation
/test |
🌐 Coverage report
|
Pinging @elastic/integrations (Team:Integrations) |
@lalit-satapathy Kindly help us add the right reviewer here. |
In packages/cassandra/kibana/dashboard/cassandra-25b7d6d0-1c71-11ec-84f1-e1733c643874.json file I still see occurrences of the snapshot version : "version": "7.15.0-SNAPSHOT" |
@@ -1,3 +1,8 @@ | |||
- version: "1.2.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are tagging this as enhancement, we should bump the minor version to 1.3.0
Else we should make it a bugfix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense, Updated.
This is not relevant to this PR. we don't need to change it as bug was specific to visualization. |
Ideally, we should not have any dashboards with the snapshot version of stack. |
There are actually multiple reasons to crashing of dashboards and main reason was because of multiple references of index patterns in dashboard's json. i guess you can refer this issue and conversation. |
I am not clear with this dashboard change being present in this change. Let's discuss it in today's meeting. |
Sure, we can dig deeper into it in today's sync. FYI, there are a lot of other integrations whose visualizations contain the snapshot version of the stack. One such example: Line 75 in 5176089
|
As discussed yesterday, For now approving this. |
What does this PR do?
Checklist
How to test this PR locally
elastic-package test
Related issues