Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cassandra] Fix dashboard issues. #3287

Merged

Conversation

kush-elastic
Copy link
Collaborator

  • Bugfix

What does this PR do?

  • Fix Cassandra dashboard issues.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/cassandra directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

@elasticmachine
Copy link

elasticmachine commented May 6, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-02T11:55:00.000+0000

  • Duration: 17 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 33
Skipped 0
Total 33

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kush-elastic
Copy link
Collaborator Author

/test

@elasticmachine
Copy link

elasticmachine commented May 6, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (13/13) 💚
Lines 100.0% (34/34) 💚
Conditionals 100.0% (0/0) 💚

@kush-elastic kush-elastic marked this pull request as ready for review May 9, 2022 06:02
@kush-elastic kush-elastic requested a review from a team as a code owner May 9, 2022 06:02
@yug-rajani yug-rajani added bug Something isn't working Team:Integrations Label for the Integrations team Integration:Cassandra dashboard labels May 9, 2022
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@yug-rajani yug-rajani requested a review from andrewkroh May 9, 2022 06:06
@yug-rajani yug-rajani added the Team:Service-Integrations Label for the Service Integrations team label May 16, 2022
@yug-rajani
Copy link
Contributor

@lalit-satapathy Kindly help us add the right reviewer here.
CC: @akshay-saraswat

@ishleenk17 ishleenk17 requested a review from a team June 2, 2022 07:09
@ishleenk17
Copy link
Contributor

In packages/cassandra/kibana/dashboard/cassandra-25b7d6d0-1c71-11ec-84f1-e1733c643874.json file I still see occurrences of the snapshot version : "version": "7.15.0-SNAPSHOT"

@@ -1,3 +1,8 @@
- version: "1.2.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are tagging this as enhancement, we should bump the minor version to 1.3.0
Else we should make it a bugfix.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, Updated.

@ishleenk17 ishleenk17 requested a review from a team June 2, 2022 07:14
@kush-elastic
Copy link
Collaborator Author

In packages/cassandra/kibana/dashboard/cassandra-25b7d6d0-1c71-11ec-84f1-e1733c643874.json file I still see occurrences of the snapshot version : "version": "7.15.0-SNAPSHOT"

This is not relevant to this PR. we don't need to change it as bug was specific to visualization.

@ishleenk17
Copy link
Contributor

In packages/cassandra/kibana/dashboard/cassandra-25b7d6d0-1c71-11ec-84f1-e1733c643874.json file I still see occurrences of the snapshot version : "version": "7.15.0-SNAPSHOT"

This is not relevant to this PR. we don't need to change it as bug was specific to visualisation.

Ideally, we should not have any dashboards with the snapshot version of stack.
If this is not relevant to this issue, why is it being picked in this PR ?

@kush-elastic
Copy link
Collaborator Author

kush-elastic commented Jun 3, 2022

Ideally, we should not have any dashboards with the snapshot version of stack. If this is not relevant to this issue, why is it being picked in this PR ?

There are actually multiple reasons to crashing of dashboards and main reason was because of multiple references of index patterns in dashboard's json. i guess you can refer this issue and conversation.

@ishleenk17
Copy link
Contributor

Ideally, we should not have any dashboards with the snapshot version of stack. If this is not relevant to this issue, why is it being picked in this PR ?

There are actually multiple reasons to crashing of dashboards and main reason was because of multiple references of index patterns in dashboard's json. i guess you can refer this issue and conversation.

I am not clear with this dashboard change being present in this change. Let's discuss it in today's meeting.

@kush-elastic
Copy link
Collaborator Author

kush-elastic commented Jun 8, 2022

cassandra-25b7d6d0-1c71-11ec-84f1-e1733c643874.json

Sure, we can dig deeper into it in today's sync. FYI, there are a lot of other integrations whose visualizations contain the snapshot version of the stack. One such example:

@ishleenk17
Copy link
Contributor

cassandra-25b7d6d0-1c71-11ec-84f1-e1733c643874.json

Sure, we can dig deeper into it in today's sync. FYI, there are a lot of other integrations whose visualizations contain the snapshot version of the stack. One such example:

As discussed yesterday, please ensure that another issue is opened up where you take care of not using snapshot versions for the dashboards. This can cause issues (similar to this dashboard issue)

For now approving this.

@kush-elastic kush-elastic merged commit d6099b1 into elastic:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dashboard Integration:Cassandra Team:Integrations Label for the Integrations team Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cassandra] [Logs Cassandra] System Logs dashboard is broken
4 participants