[snort] Format {source,destination}.mac per ECS #3301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[git-generate] cd packages/snort yq -i '. | sort_by(.name) | sort_keys(..)' data_stream/log/fields/ecs.yml
event.category event.created event.kind event.original event.timezone event.type
The error was:
expected type "date" for required field "@timestamp"
[git-generate] cd packages/snort elastic-package build elastic-package test pipeline -g
[git-generate] elastic-package-changelog add-next --pr 3301 --type bug --description "Format source.mac and destination.mac as per ECS and add missing mappings for various event.* fields."
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
r00tu53r
approved these changes
May 10, 2022
This was referenced May 22, 2022
andrewkroh
added a commit
that referenced
this pull request
Jun 28, 2022
This updates the ECS version used in all non-deprecated packages owned by elastic/security-external-integrations. These packages required fixes in order to comply with the `pattern` added to ECS to validate MAC addresses. - cef - #3566 - crowdstrike - #3302 - cylance.protect - #3368 - fortinet.fortimanager - #3401 - iptables.log - #3358 - microsoft_dhcp - #3300 - pfsense - #3303 - snort - #3301 - sonicwall.firewall - #3360 - sophos.utm - #3370 NOTE: The following packages were not updated for 8.2.0. I didn't catch anything in 8.1 or 8.2 that needed changed. - auth0 - 1.12.0 - carbon_black_cloud - 8.0.0 - cisco_ise - 8.0.0 - cisco_meraki - 8.0.0 - hid_bravura_monitor - 1.12.0 - modsecurity - 1.12.0 - mysql_enterprise - 8.0.0 - netskope - 8.0.0 - oracle - 8.0.0 - symantec_endpoint - 1.12.0 - ti_recordedfuture - 8.0 [git-generate] go run github.com/andrewkroh/go-examples/ecs-update@6efa1ecb3871 \ --ecs-version=8.3.0 \ -ecs-git-ref=v8.3.0 \ --pr=3353 \ --owner=elastic/security-external-integrations \ packages/*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Format the
{source,destination}.macfield as per ECS (https://www.elastic.co/guide/en/ecs/current/ecs-observer.html#field-observer-mac).Also add missing mappings for ECS
eventfields:lintwas failing so I addedtype: dateto the@timestamp. Issue reported in elastic/elastic-package#749.Checklist
changelog.ymlfile.