Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symantec_endpoint: use valid ECS values for fields #3330

Merged
merged 2 commits into from
May 12, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 11, 2022

What does this PR do?

This cleans up items missed in the previous pass in #3244. Now verified by the tool's check.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

See #3016 (comment)

Related issues

Screenshots

This cleans up items missed in the previous pass.
@efd6 efd6 requested a review from a team as a code owner May 11, 2022 12:30
@efd6 efd6 self-assigned this May 11, 2022
@elasticmachine
Copy link

elasticmachine commented May 11, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-11T12:31:49.933+0000

  • Duration: 16 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 0
Total 23

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.589
Classes 100.0% (1/1) 💚 3.589
Methods 100.0% (19/19) 💚 11.716
Lines 98.914% (820/829) 👍 9.886
Conditionals 100.0% (0/0) 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

symantec_endpoint using invalid field values according to ECS
3 participants