Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cisco_duo: fix invalid values for event.outcome #3333

Merged
merged 2 commits into from
May 11, 2022
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 11, 2022

What does this PR do?

This fixes an invalid value in event.outcome for the auth data set.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

See #3016 (comment)

Related issues

Screenshots

@efd6 efd6 self-assigned this May 11, 2022
@efd6 efd6 requested a review from a team as a code owner May 11, 2022 13:20
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented May 11, 2022

❕ Build Aborted

Either there was a build timeout or someone aborted the build.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-11T13:20:50.703+0000

  • Duration: 122 min 6 sec

Steps errors 1

Expand to view the steps failures

Google Storage Download
  • Took 0 min 0 sec . View more details here

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 3.589
Classes 100.0% (5/5) 💚 3.589
Methods 100.0% (50/50) 💚 11.716
Lines 91.506% (571/624) 👍 2.478
Conditionals 100.0% (0/0) 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working integration:Cisco Duo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cisco_ftd, cisco_duo using invalid values according to ECS
3 participants