Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cisco_ftd] Add TLS system test #3339

Merged
merged 3 commits into from
May 12, 2022

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented May 11, 2022

What does this PR do?

  • Add system test for TLS using TCP input
  • Fix issues flagged by check

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/cisco_ftd && elastic-package test system

Related issues

- Add system test for TLS using TCP input
- Fix issues flagged by check
@taylor-swanson taylor-swanson added enhancement New feature or request Team:Security-External Integrations Integration:CiscoFTD Cisco FTD Firepower Threat Defense labels May 11, 2022
@taylor-swanson taylor-swanson self-assigned this May 11, 2022
@elasticmachine
Copy link

elasticmachine commented May 11, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-12T07:54:49.163+0000

  • Duration: 18 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 11, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.597
Classes 100.0% (1/1) 💚 3.597
Methods 100.0% (17/17) 💚 11.753
Lines 66.522% (1073/1613) 👎 -22.591
Conditionals 100.0% (0/0) 💚

@taylor-swanson taylor-swanson marked this pull request as ready for review May 11, 2022 18:12
@taylor-swanson taylor-swanson requested a review from a team as a code owner May 11, 2022 18:12
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:CiscoFTD Cisco FTD Firepower Threat Defense
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants