Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[google_workspace] Allow to set credentials directly in the config. #3430

Merged
merged 5 commits into from
Jun 8, 2022
Merged

[google_workspace] Allow to set credentials directly in the config. #3430

merged 5 commits into from
Jun 8, 2022

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented May 25, 2022 •
edited
Loading

What does this PR do?

Adds an option to set up credentials directly in the UI instead of using a file.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@marc-gr marc-gr requested a review from a team as a code owner May 25, 2022 14:51
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@marc-gr marc-gr changed the title Allow to set credentials directly in the config. [google_workspace] Allow to set credentials directly in the config. May 25, 2022
@elasticmachine
Copy link

elasticmachine commented May 25, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-08T09:29:08.458+0000

  • Duration: 19 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 45
Skipped 0
Total 45

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@marc-gr
Copy link
Contributor Author

marc-gr commented Jun 1, 2022

/test

1 similar comment
@marc-gr
Copy link
Contributor Author

marc-gr commented Jun 2, 2022

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚 3.497
Classes 100.0% (6/6) 💚 3.497
Methods 100.0% (80/80) 💚 10.61
Lines 96.727% (1596/1650) 👍 5.936
Conditionals 100.0% (0/0) 💚

adriansr
adriansr approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr marc-gr merged commit 8bebafa into elastic:main Jun 8, 2022
@marc-gr marc-gr deleted the gw_creds_json branch June 8, 2022 10:00
@kcreddy kcreddy mentioned this pull request Jun 8, 2022
Merged
4 tasks
@andrewkroh andrewkroh mentioned this pull request Jun 9, 2022
Merged
@terrancedejesus terrancedejesus mentioned this pull request Jan 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansr adriansr adriansr approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:Google Workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[google_workspace] Add config option alternatives that don't depend on reading local files
3 participants
@marc-gr @elasticmachine @adriansr